From 768c9e2024140537672a453432c0cc8b1d25ca29 Mon Sep 17 00:00:00 2001
From: Seth Call <sethcall@gmail.com>
Date: Tue, 3 Feb 2015 09:49:19 -0600
Subject: [PATCH] VRFS-2739 - remove aggressive check for bad session info and
 add some basic tests to catch errors in the future

---
 .../assets/javascripts/notificationPanel.js   |  6 +--
 web/app/views/clients/_sidebar.html.erb       |  2 +-
 web/spec/features/notification_spec.rb        | 38 +++++++++++++++++++
 3 files changed, 42 insertions(+), 4 deletions(-)
 create mode 100644 web/spec/features/notification_spec.rb

diff --git a/web/app/assets/javascripts/notificationPanel.js b/web/app/assets/javascripts/notificationPanel.js
index fdf0ac3ee..7c3e608de 100644
--- a/web/app/assets/javascripts/notificationPanel.js
+++ b/web/app/assets/javascripts/notificationPanel.js
@@ -221,9 +221,9 @@
       $.each(response, function(index, val) {
 
         // this means the session no longer exists
-        if (response.fan_access == null && response.musician_access == null) {
-          return;
-        }
+        //if (response.fan_access == null && response.musician_access == null) {
+        //  return;
+        //}
 
         if(val.description == context.JK.MessageType.TEXT_MESSAGE) {
           val.formatted_msg = textMessageDialog.formatTextMessage(val.message.substring(0, 200), val.source_user_id, val.source_user.name, val.message.length > 200).html();
diff --git a/web/app/views/clients/_sidebar.html.erb b/web/app/views/clients/_sidebar.html.erb
index dbb92c66a..b8d44dc68 100644
--- a/web/app/views/clients/_sidebar.html.erb
+++ b/web/app/views/clients/_sidebar.html.erb
@@ -210,7 +210,7 @@
 
 <!-- Notification panel template -->
 <script type="text/template" id="template-notification-panel">
-  <li session-id="{sessionId}" notification-id="{notificationId}">
+  <li class="notification-entry" session-id="{sessionId}" notification-id="{notificationId}">
     <div class="avatar-small" user-id="{userId}" hoveraction="musician"><img src="{avatar_url}" /></div>
     <div session-id="{sessionId}" hoveraction="hoveraction" class="note-text">
       {text}<br/>
diff --git a/web/spec/features/notification_spec.rb b/web/spec/features/notification_spec.rb
new file mode 100644
index 000000000..baa9d2075
--- /dev/null
+++ b/web/spec/features/notification_spec.rb
@@ -0,0 +1,38 @@
+require 'spec_helper'
+
+describe "Notification Subpanel", :js => true, :type => :feature, :capybara_feature => true  do
+
+  subject { page }
+
+
+  let(:user) { FactoryGirl.create(:user, last_jam_locidispid: 1) }
+
+
+
+  describe "user with no notifications" do
+    before(:each) do
+      fast_signin(user, "/client")
+    end
+
+    it "lists no notifications" do
+      open_notifications
+      expect(page).to have_selector("#{NOTIFICATION_PANEL} li.notification-entry", count: 0)
+    end
+  end
+
+  describe "user with 1 notification" do
+
+    let!(:other) { FactoryGirl.create(:user, last_jam_locidispid: 1) }
+    let!(:msg1) {FactoryGirl.create(:notification_text_message, source_user: other, target_user: user) }
+
+    before(:each) do
+      fast_signin(user, "/client")
+
+    end
+
+    it "lists 1 notifications" do
+      open_notifications
+      expect(page).to have_selector("#{NOTIFICATION_PANEL} li.notification-entry", count: 1)
+    end
+  end
+end
\ No newline at end of file