seth
/
jam-cloud
mirror of https://bitbucket.org/jamkazam/jam-cloud.git
1
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity

* brought back two pending test

This commit is contained in:
Seth Call 2014-05-19 18:49:02 -05:00
parent 1f86b809ff
commit a0fbd433b3
3 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
web/app/assets/javascripts/fakeJamClientRecordings.js
View File

@ -34,8 +34,8 @@
function StartRecording(recordingId, clients) {
startingSessionState = {};
// we expect all clients to respond within 3 seconds to mimic the reliable UDP layer
startingSessionState.aggegratingStartResultsTimer = setTimeout(timeoutStartRecordingTimer, 3000);
// we expect all clients to respond within 1 seconds to mimic the reliable UDP layer
startingSessionState.aggegratingStartResultsTimer = setTimeout(timeoutStartRecordingTimer, 1000);
startingSessionState.recordingId = recordingId;
startingSessionState.groupedClientTracks = copyClientIds(clients, app.clientId); // we will manipulate this new one
@ -70,8 +70,8 @@
stoppingSessionState = {};
// we expect all clients to respond within 3 seconds to mimic the reliable UDP layer
stoppingSessionState.aggegratingStopResultsTimer = setTimeout(timeoutStopRecordingTimer, 3000);
// we expect all clients to respond within 1 seconds to mimic the reliable UDP layer
stoppingSessionState.aggegratingStopResultsTimer = setTimeout(timeoutStopRecordingTimer, 1000);
stoppingSessionState.recordingId = recordingId;
stoppingSessionState.groupedClientTracks = copyClientIds(clients, app.clientId);

1
web/app/assets/javascripts/session.js
View File

@ -385,6 +385,7 @@
})
.on('stoppedRecording', function(e, data) {
if(data.reason) {
logger.warn("Recording Discarded: ", data);
var reason = data.reason;
var detail = data.detail;

6
web/spec/features/recordings_spec.rb
View File

@ -47,11 +47,10 @@ describe "Session Recordings", :js => true, :type => :feature, :capybara_feature
# confirms that if someone leaves 'ugly' (without calling 'Leave' REST API), that the recording is junked
it "creator starts and then abruptly leave" do
pending "shows 'recording finished'"
start_recording_with(creator, [joiner1])
in_client(creator) do
close_websocket
visit "/request_reset_password" # kills websocket, looking like an abrupt leave
end
in_client(joiner1) do
@ -81,11 +80,10 @@ describe "Session Recordings", :js => true, :type => :feature, :capybara_feature
# confirms that if someone leaves 'ugly' (without calling 'Leave' REST API), that the recording is junked with 3 participants
it "creator starts and then abruptly leave with 3 participants" do
pending "shows 'recording finished'"
start_recording_with(creator, [joiner1, joiner2])
in_client(creator) do
close_websocket
visit "/request_reset_password" # kills websocket, looking like an abrupt leave
end
in_client(joiner1) do