From afc9c55b9f45d4dfca73838683587b03c19e1b10 Mon Sep 17 00:00:00 2001 From: Nuwan Date: Sat, 5 Apr 2025 21:48:38 +0530 Subject: [PATCH] PR change requests. moved email sernding job to hourly job tasks. and add database table index --- .../20250227125441_add_profile_complete_columns_to_users.rb | 2 ++ ruby/lib/jam_ruby/resque/scheduled/hourly_job.rb | 1 + web/config/scheduler.yml | 5 ----- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/ruby/db/migrate/20250227125441_add_profile_complete_columns_to_users.rb b/ruby/db/migrate/20250227125441_add_profile_complete_columns_to_users.rb index 282f68eb0..cef65f792 100644 --- a/ruby/db/migrate/20250227125441_add_profile_complete_columns_to_users.rb +++ b/ruby/db/migrate/20250227125441_add_profile_complete_columns_to_users.rb @@ -1,6 +1,8 @@ class AddProfileCompleteColumnsToUsers < ActiveRecord::Migration def self.up execute "ALTER TABLE users ADD COLUMN profile_completed_at TIMESTAMP" + #add index on profile_completed_at + execute "CREATE INDEX index_users_on_profile_completed_at ON users USING btree (profile_completed_at)" execute "ALTER TABLE users ADD COLUMN profile_complete_reminder1_sent_at TIMESTAMP" execute "ALTER TABLE users ADD COLUMN profile_complete_reminder2_sent_at TIMESTAMP" execute "ALTER TABLE users ADD COLUMN profile_complete_reminder3_sent_at TIMESTAMP" diff --git a/ruby/lib/jam_ruby/resque/scheduled/hourly_job.rb b/ruby/lib/jam_ruby/resque/scheduled/hourly_job.rb index e534e98cf..a73b813b9 100644 --- a/ruby/lib/jam_ruby/resque/scheduled/hourly_job.rb +++ b/ruby/lib/jam_ruby/resque/scheduled/hourly_job.rb @@ -13,6 +13,7 @@ module JamRuby #TeacherPayment.hourly_check User.hourly_check AffiliatePartner.tally_up(Date.today) + EmailProfileReminder.send_reminders ConnectionManager.new.cleanup_dangling @@log.info("done") diff --git a/web/config/scheduler.yml b/web/config/scheduler.yml index dc33e9e4b..e3c09c2ae 100644 --- a/web/config/scheduler.yml +++ b/web/config/scheduler.yml @@ -70,11 +70,6 @@ NewMusicianMatchEmailer: class: "JamRuby::NewMusicianMatchEmailer" description: "Sends weekly emails of new users with good latency - (User latency data from neo4j)" -ProfileReminderEmailer: - cron: "0 23 * * *" # 11pm - class: "JamRuby::ProfileReminderEmailer" - description: "Sends emails reminding users to complete their profile" - MusicSessionScheduler: cron: "0 * * * *" class: "JamRuby::MusicSessionScheduler"